Antoine Pelisse <apelisse@xxxxxxxxx> writes: > +/* Coalesce new lines into base by finding LCS */ > +static struct lline *coalesce_lines(struct lline *base, int *lenbase, > + struct lline *new, int lennew, > + unsigned long parent) > +{ Don't you want to pass flags so that you can use match_string_spaces() at places like this: > + for (i = 1, baseend = base; i < origbaselen + 1; i++) { > + for (j = 1, newend = new; j < lennew + 1; j++) { > + if (baseend->len == newend->len && > + !memcmp(baseend->line, newend->line, baseend->len)) { IOW, it looks to me that this wants to be rebuilt on top of fa04ae0be8cc (Allow combined diff to ignore white-spaces, 2013-03-14). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html