On Sat, Mar 9, 2013 at 5:40 PM, Duy Nguyen <pclouds@xxxxxxxxx> wrote: > On Sat, Mar 9, 2013 at 3:42 PM, Fredrik Gustafsson <iveqy@xxxxxxxxx> wrote: >> To improve performance. > > BTW, by rolling our own string comparison, we may lose certain > optimizations done by C library. In case of glibc, it may choose to > run an sse4.2 version where 16 bytes are compared at a time. Maybe we > encounter "string not equal" much often than "string equal" and such > an optimization is unncessary, I don't know. Measured numbers say it's > unncessary as my cpu supports sse4.2. Another problem is locale. Git's toupper() does not care about locale, which should be fine in most cases. strcasecmp is locale-aware, our new str[n]equal_icase is not. It probably does not matter for (ascii-based) pathnames, I guess. core.ignorecase users, any comments? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html