On 03/07/13 20:51, Junio C Hamano wrote: > But it is equally broken to behave as if there is nothing wrong in > the incomplete magic ":(top" that is not closed, isn't it? Ah, yea, I did notice that, but then I saw a few lines below: if (*copyfrom == ')') copyfrom++; which is explicitly making the ")" optional. So I thought maybe that was the original intention, and left it at that. Though the doc says to end with ")", so I guess it should error out after all? If that's the case, I can try to come up with a patch to error it out (through die() ?). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html