Re: [PATCH 2/2] bundle: Add colons to list headings in "verify"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lukas Fleischer <git@xxxxxxxxxxxxxx> writes:

> These slightly improve the reading flow by making it obvious that a list
> follows.
>
> Signed-off-by: Lukas Fleischer <git@xxxxxxxxxxxxxx>

Perhaps.

The earlier message says "contains X ref(s)" while the later one
says "requires this/these X ref(s)".  Do we want to make them
consistent, too?

> ---
>  bundle.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/bundle.c b/bundle.c
> index 65db53b..8cd8b4f 100644
> --- a/bundle.c
> +++ b/bundle.c
> @@ -183,8 +183,8 @@ int verify_bundle(struct bundle_header *header, int verbose)
>  		struct ref_list *r;
>  
>  		r = &header->references;
> -		printf_ln(Q_("The bundle contains %d ref",
> -			     "The bundle contains %d refs",
> +		printf_ln(Q_("The bundle contains %d ref:",
> +			     "The bundle contains %d refs:",
>  			     r->nr),
>  			  r->nr);
>  		list_refs(r, 0, NULL);
> @@ -192,8 +192,8 @@ int verify_bundle(struct bundle_header *header, int verbose)
>  		if (!r->nr) {
>  			printf_ln(_("The bundle records a complete history."));
>  		} else {
> -			printf_ln(Q_("The bundle requires this ref",
> -				     "The bundle requires these %d refs",
> +			printf_ln(Q_("The bundle requires this ref:",
> +				     "The bundle requires these %d refs:",
>  				     r->nr),
>  				  r->nr);
>  			list_refs(r, 0, NULL);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]