On Thu, 11 Jan 2007, Alex Riesen wrote: > On 1/11/07, Linus Torvalds <torvalds@xxxxxxxx> wrote: > > That said, I think we actually have another problem entirely: > > > > Look at "write_cache()", Junio: isn't it leaking memory like mad? > > Unless it is used in some corner case not covered by tests - it > looks like it does leak memory like mad. With the patch the > memory usage for 44k-merge is more than halved! Is that halving on _top_ of your and Junio's fixes to not flush unnecessarily? Junio, I looked and looked, and that trivial one-liner definitely looks right to me. The pointer is not free'd by anybody else, and none of the things we call in to with it save it away, and they expect the caller to manage it. And it does pass all the tests, although I don't know how much coverage they have in this area.. Linus - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html