Duy Nguyen <pclouds@xxxxxxxxx> writes: > This "return NULL;" means we ignore "!blah" pattern, which is a > regression, isn't it? Should we treat '!' as literal here? Probably not. Can you point to a project everybody has heard of that keeps track of a path that begins with an exclamation point? With clarification to the documentation that says "you cannot use ! to negate" and your "die on such an entry", we have been going in the direction that forbids the use of such an entry, and making it mean literal exclamation point is going sideways in the middle of the road. Besides, if you want to match a path that begins with an exclam, you can always say "[!]", no? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html