Re: What's cooking in git.git (topics)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:

> BTW I am not quite sure if you missed this patch: 
> http://thread.gmane.org/gmane.comp.version-control.git/36212/, or if you 
> did not like it, want enhancements, ...

It is still sitting in my in-box; I tend to agree with Shawn in
that mixing the reflog sequence and true parenthood in the same
traversal is kind of insane.  I vaguely recall you thought
dropping that would make the code simpler, and was kind of
waiting for that to happen to review the results.

Also I did not quite understand your comment about circular log
entries.

When you walk the reflog, the entries are by definition a single
strand of pearls (reflog itself is a flat text file which you
read linearly).  The commits adjacent entries talk about may or
may not be related at all, and two entries may happen to point
at the same commit.  But I do not think the appearance of
another reflog entry in an earlier call to get_revision() should
not cause a reflog entry to be dropped from the output only
because it points at the same commit.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]