On Fri, Feb 22, 2013 at 6:03 PM, Joshua Clayton <stillcompiling@xxxxxxxxx> wrote: > Read and write each 1024 byte buffer, rather than trying to buffer > the entire content of the file. > Previous code would crash on all files > 2 Gib, when the offset variable > became negative (perhaps below the level of perl), resulting in a crash. > On a 32 bit system, or a system with low memory it might crash before > reaching 2 GiB due to memory exhaustion. > > Signed-off-by: Joshua Clayton <stillcompiling@xxxxxxxxx> We usually put "Reviewed-by: Name <email>" right below the SoB-line, rather than in the subject. And then we CC the people who were involved in the previous round :) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html