Adam Spiers <git@xxxxxxxxxxxxxx> writes:
> test_expect_success_multi() helper function warrants some explanation,
> since at first sight it may seem like generic test framework plumbing,
> but is in fact specific to testing check-ignore, and allows more
> thorough testing of the various output formats without significantly
> increase the size of t0008.
>
> Signed-off-by: Adam Spiers <git@xxxxxxxxxxxxxx>
> ---
Good. I vaguely recall saying why I hate these mini-frameworks
invented in individual tests, but with comments like this, they
become much more palatable.
Thanks.
> t/t0008-ignores.sh | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/t/t0008-ignores.sh b/t/t0008-ignores.sh
> index d7df719..ebe7c70 100755
> --- a/t/t0008-ignores.sh
> +++ b/t/t0008-ignores.sh
> @@ -75,6 +75,16 @@ test_check_ignore () {
> stderr_empty_on_success "$expect_code"
> }
>
> +# Runs the same code with 3 different levels of output verbosity,
> +# expecting success each time. Takes advantage of the fact that
> +# check-ignore --verbose output is the same as normal output except
> +# for the extra first column.
> +#
> +# Arguments:
> +# - (optional) prereqs for this test, e.g. 'SYMLINKS'
> +# - test name
> +# - output to expect from -v / --verbose mode
> +# - code to run (should invoke test_check_ignore)
> test_expect_success_multi () {
> prereq=
> if test $# -eq 4
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html