Jeff King wrote: > Originally packets were used just for the line-oriented ref > advertisement and negotiation. These days, we also stuff > packfiles and sidebands into them, and they do not > necessarily represent a line. Drop the "_line" suffix, as it > is not informative and makes the function names quite long > (especially as we add "_gently" and other variants). > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > Again, this is a taste issue. Can be optional. In combination with patch 3, this changes the meaning of packet_read() without changing its signature, which could make other patches cherry-picked on top change behavior in unpredictable ways. :( So I'd be all for this if the signature changes (for example to put the fd at the end or something), but not so if not. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html