On Mon, Feb 18, 2013 at 01:29:16AM -0800, Junio C Hamano wrote: > > I just checked, and GitHub also does not send flush packets after ERR. > > Which makes sense; ERR is supposed to end the conversation. > > Hmph. A flush packet was supposed to be a mark to say "all the > packets before this one can be buffered and kept without getting > passed to write(2), but this and all such buffered data _must_ go on > the wire _now_". So in the sense, ERR not followed by a flush may > not even have a chance to be seen on the other end, no? That is > what the comment before the implementation of packet_flush() is all > about. Despite the name, I always thought of packet_flush as more of a signal for the _receiver_, who then knows that they have gotten all of a particular list. In other words, we seem to use it as a sequence point as much as anything (mostly because we immediately write() out any other packets anyway, so there is no flushing to be done; but perhaps there were originally thoughts that we could do more buffering on the writing side). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html