On Sat, Feb 16, 2013 at 2:32 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> If you consider read_directory_recursive alone, there is a regression. >> The return value of r_d_r depends on path_handled/path_ignored. With >> this patch, the return value will be different. > > That is exactly what was missing from the proposed log message, and > made me ask "Do all the callers that reach this function in their > callgraph, when they get path_ignored for a path in the index, > behave as if the difference between path_ignored and path_handled > does not matter?" I'll add it the the log message. Although I'm thinking some restructuring to separate tracked file handling from the rest may make it clearer (and less error prone in future). -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html