On Mon, Feb 11, 2013 at 01:34:52PM -0800, Junio C Hamano wrote: > Two points and a possibly irrelevant half: > > - If a fix is platform specific (i.e. tempts to use #ifdef > PLATFORM_NAME), we would prefer to see a patch that that is > isolated to platform-specific compatibility layer, which would > involve: > > . add compat/qnx/expat.h file that #include <xmlparse.h> > . to Makefile, add -Icompat/qnx/ to CFLAGS > > - Is this really a fix for a problem specific to QNX? It looks > like this is for any platform with expat 1, no? It should apply to anyone trying to build with expat 1.1 or 1.2, but not with 1.95.0 or later. > - What happens to people with QNX older than 6.3.2 or newer than > 6.5.0 (assuming they will eventually start shipping expat 2) with > your patch? Git will fail to build http-push.c. I don't know if QNX will ever update expat, though. expat 1.95.0 was released in 2000, expat 2.0.0 was released in 2006, and QNX 6.5.0 was released in 2010. > Assuming that this change is about building with expat1, it would > probably be better to do something like this instead, I would think. expat 1.95.0 through 1.95.8 used expat.h; should I still use EXPAT_VERSION = 1 to signify that it should use xmlparse.h, use EXPAT_NEEDS_XMLPARSE_H as Jeff suggested, or something else entirely? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html