On Sun, Jan 27, 2013 at 6:34 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Brandon Casey wrote:
>
>> --- a/sequencer.c
>> +++ b/sequencer.c
>> @@ -497,6 +558,8 @@ static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
>> }
>>
>> if (opts->record_origin) {
>> + if (!has_conforming_footer(&msgbuf, 0))
>> + strbuf_addch(&msgbuf, '\n');
>
> What should this do in the case of an entirely blank message?
> (Maybe that's too insane a case to worry about.)
Yeah, I think there are a number of insane cases that I think we
should just say "behavior is undefined".
- Entirely blank message
- Message lacking trailing newline.
- Oneline message that is actually a signed-off-by (equal or not to
the committer's sob).
- Message body that is entirely 1 or more newlines, or one which has
more than one trailing newline.
It's probably not worth going through contortions to handle these cases.
-Brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html