On Fri, Feb 08, 2013 at 07:09:28AM -0800, Matt Kraai wrote: > From: Matt Kraai <matt.kraai@xxxxxxxxxxxxxx> > > QNX 6.3.2 uses GCC 2.95.3 by default, and GCC 2.95.3 doesn't remove the > comma if the error macro's variable argument is left out. > > Instead of testing for a sufficiently recent version of GCC, make > __VA_ARGS__ match all of the arguments. > > [...] > > /* > * Let callers be aware of the constant return value; this can help > - * gcc with -Wuninitialized analysis. We have to restrict this trick to > - * gcc, though, because of the variadic macro and the magic ## comma pasting > - * behavior. But since we're only trying to help gcc, anyway, it's OK; other > - * compilers will fall back to using the function as usual. > + * gcc with -Wuninitialized analysis. We restrict this trick to gcc, though, > + * because some compilers may not support variadic macros. Since we're only > + * trying to help gcc, anyway, it's OK; other compilers will fall back to > + * using the function as usual. > */ > #if defined(__GNUC__) && ! defined(__clang__) > -#define error(fmt, ...) (error((fmt), ##__VA_ARGS__), -1) > +#define error(...) (error(__VA_ARGS__), -1) Acked-by: Jeff King <peff@xxxxxxxx> Thanks. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html