Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes: > Michal Nazarewicz <mpn@xxxxxxxxxx> writes: > >> From: Michal Nazarewicz <mina86@xxxxxxxxxx> >> >> Add a credential() function which is an interface to the git >> credential command. The code is heavily based on credential_* >> functions in <contrib/mw-to-git/git-remote-mediawiki>. > > I'm no perl expert, so I cannot comment much on style (there are many > small changes compared to the mediawiki code that look like improvement > though), but: > > Reviewed-by: Matthieu Moy <Matthieu.Moy@xxxxxxx> Thanks. I'd actually be more worried about the error checking issue Peff raised during his review. I have a feeling that "when in doubt, do not cause harm" is a more prudent way to go than "I do not know, so I'll let anything pass". -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html