On Thu, Feb 07, 2013 at 01:05:19PM -0800, Junio C Hamano wrote: > Matt Kraai <kraai@xxxxxxxxx> writes: > > > -#if defined(__GNUC__) && ! defined(__clang__) > > -#define error(fmt, ...) (error((fmt), ##__VA_ARGS__), -1) > > -#endif > > +#define error(...) (error(__VA_ARGS__), -1) > > Before your change, we only define error() macro for GCC variants, > but with your patch that no longer is the case. Does every compiler > that compiles Git correctly today support this style of varargs > macros? At the very least the "! defined(__clang__)" was only recently added [1], although it shouldn't be needed once Clang 3.3 is released. [1] http://article.gmane.org/gmane.comp.version-control.git/213787 John -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html