Re: [PATCH] connect.c: Tell *PLink to always use ssh protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 06, 2013 at 10:58:49PM +0100, Sven Strickroth wrote:

> Default values for *plink can be set using PuTTY. If a user makes
> telnet the default in PuTTY this breaks ssh clones in git.
> 
> Since git clones of the type user@host:path use ssh, tell *plink
> to use ssh and override PuTTY defaults for the protocol to use.
> 
> Signed-off-by: Sven Strickroth <email@xxxxxxxxxx>

Makes sense to me, though I'd expect to see this cc'd to the msysgit
list (which I'm doing on this response) for comment from people who
might be more familiar with the area.

Quoted patch follows.

-Peff

> ---
>  connect.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/connect.c b/connect.c
> index 49e56ba..d337b6f 100644
> --- a/connect.c
> +++ b/connect.c
> @@ -625,6 +625,8 @@ struct child_process *git_connect(int fd[2], const char *url_orig,
>  		if (!ssh) ssh = "ssh";
>  
>  		*arg++ = ssh;
> +		if (putty)
> +			*arg++ = "-ssh";
>  		if (putty && !strcasestr(ssh, "tortoiseplink"))
>  			*arg++ = "-batch";
>  		if (port) {
> -- 
> Best regards,
>  Sven Strickroth
>  PGP key id F5A9D4C4 @ any key-server
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]