Junio C Hamano <gitster@xxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> I suspect somebody from the Windows camp saw a patch I posted >> without the ifdef, noticed that there is a problem to expect >> IDENT_NAME_GIVEN to be set on Windows for some reason, and resulted >> in a reroll of the function in that shape. >> >> I didn't find anything in the list archive, though. So I am >> stumped. > > The only thing I can think of is that on Unix we can guess name from > GECOS, which could be considered sufficiently your name, while on > Windows we probably do not get anything useful there. http://thread.gmane.org/gmane.comp.version-control.git/137312/focus=137345 These days, we encourage setting user.name explicitly even on a system on which it is likely that we will see a good GECOS value, so removing the ifdef and always check with ALL may not hurt anybody. I dunno. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html