greened@xxxxxxxxxxxxx writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> "David A. Greene" <greened@xxxxxxxxxxxxx> writes: >> >>> +test_create_commit() ( >>> + repo=$1 >>> + commit=$2 >>> + cd "$repo" >>> + mkdir -p "$(dirname "$commit")" >>> + echo "$commit" > "$commit" >> >> Style. > > I need a little more explanation. :) Is there a style guide somewhere? Documentation/CodingGuidelines? > >>> + git add "$commit" >>> + git commit -m "$commit" >>> +) >> >> Very nice, but don't we want to check for possible errors in any of >> the above commands? > > I'll fix that. :) > ... > Ok. I'll rework this. Thanks. I also think it would be a good idea for you to learn to push back to the original authors; fixing problems in patches by others, while is a good way to learn how their thinking process went, is not necessarily fun. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html