Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> writes: > Recently and not so recently, we made sure that log/grep type operations > use textconv filters when a userfacing diff would do the same: > > ef90ab6 (pickaxe: use textconv for -S counting, 2012-10-28) > b1c2f57 (diff_grep: use textconv buffers for add/deleted files, 2012-10-28) > 0508fe5 (combine-diff: respect textconv attributes, 2011-05-23) > > "git grep" currently does not use textconv filters at all, that is > neither for displaying the match and context nor for the actual grepping. > > Introduce a binary mode "--textconv" (in addition to "--text" and "-I") > which makes git grep use any configured textconv filters for grepping > and output purposes. > > Signed-off-by: Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> > --- > > Notes: > I'm somehow stuck in textconv/filespec/... hell, so I'm sending this out > in request for help. I'm sure there are people for whom it's a breeze to > get this right. Looks like the patch touches the right places in the codepaths that need to be updated from a quick read. > The difficulty is in getting the different cases (blob/sha1 vs. > worktree) right, and in making the changes minimally invasive. I think grep_source abstraction was intended to be a way for that, and if what it gives you is not sufficient for your needs, extending it should not be seen as "invasive" at all. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html