Jeff King wrote: > We keep a list of the various files that end up as man1, > man5, etc. Let's break these single-line lists into sorted > multi-line lists, which makes diffs that touch them much > easier to read. Independentally of the rest of the series, I think this is a good cleanup. > --- a/Documentation/Makefile > +++ b/Documentation/Makefile > @@ -1,13 +1,28 @@ MAN7_TXT += gitcredentials.txt > -MAN1_TXT= \ > - $(filter-out $(addsuffix .txt, $(ARTICLES) $(SP_ARTICLES)), \ > - $(wildcard git-*.txt)) \ > - gitk.txt gitweb.txt git.txt > +MAN1_TXT += git.txt > +MAN1_TXT += gitk.txt > +MAN1_TXT += gitweb.txt > + If the user happens to have MAN[157]_TXT set in the environment, this would be affected by that. How about: # Guard against environment variables MAN1_TXT = MAN5_TXT = MAN7_TXT = MAN1_TXT += ... ... ? With that change, Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html