From: "Gustavo L. de M. Chaves" <gnustavo@xxxxxxxx>
The Git::activestate_pipe::CLOSE routine wasn't explicitly returning
anything. This means that on Windows the routine _cmd_close wasn't
checking correctly the external command's exit code.
Now we store the command's exit code on the object created by
Git::activestate_pipe::TIEHANDLE and return a sensible value on
Git::activestate_pipe::CLOSE to _cmd_close.
Signed-off-by: Gustavo L. de M. Chaves <gnustavo@xxxxxxxx>
---
perl/Git.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/perl/Git.pm b/perl/Git.pm
index e14b41a..ef3134b 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -1404,7 +1404,7 @@ sub TIEHANDLE {
# Let's just hope ActiveState Perl does at least the quoting
# correctly.
my @data = qx{git @params};
- bless { i => 0, data => \@data }, $class;
+ bless { i => 0, data => \@data, exit => $? }, $class;
}
sub READLINE {
@@ -1425,6 +1425,7 @@ sub CLOSE {
my $self = shift;
delete $self->{data};
delete $self->{i};
+ return $self->{exit} == 0;
}
sub EOF {
--
1.7.12.464.g83379df.dirty
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html