On Tue, Jan 29, 2013 at 4:16 PM, Jeff King <peff@xxxxxxxx> wrote: > +int commit_metapack(unsigned char *sha1, > + uint32_t *timestamp, > + unsigned char **tree, > + unsigned char **parent1, > + unsigned char **parent2) > +{ Nit picking. tree, parent1 and parent2 can/should be "const unsigned char **". -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html