On Sun, Jan 27, 2013 at 6:27 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > David Aguilar <davvid@xxxxxxxxx> writes: > >> On Sun, Jan 27, 2013 at 6:08 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >>> I think our works crossed, while I was tweaking the previous series >>> to push out as part of 'pu' you were already rerolling. Could you >>> compare this series with what I pushed out and see if anything you >>> missed? I think I fixed the (a && b || c && d) issue in the version >>> I pushed out, but it is still there in this series. >> >> Ah, I see. >> >> I can add the addition of preamble for use by show_tool_help() >> as a follow up along with using a here-doc when printing. > > I think the progression of the series is just fine as-is with the > new series you posted (I didn't amend the old one with all the > suggestions I made in the review, just only with the more important > ones that would affect correctness, so please consider that the > changes you have in this new round that I didn't have in 'pu' are > good ones to keep. Okay, cool, so no need to reroll, ya? The one thing missing in my latest series was the fixed mode_ok() which you corrected in cfb611b34089a0b5794f4ec453289a4764d94050. Let me know if there's anything else I should send out or splice together. John, I didn't completely address your question about keeping the sort and prefix in show_tool_help() but I can stop poking at it now in case you want to start looking at what it would take to get custom tools listed in the --tool-help output. -- David -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html