Am 27.01.2013 22:24, schrieb David Aguilar: > Use $(command "$arg") instead of "$(command "$arg")" as the latter is > harder to read. If at all, you should restrict yourself to simplify only variable assignments. Because this case: > - if test -z "$(get_merge_tool_cmd "$merge_tool")" && > + if test -z $(get_merge_tool_cmd "$merge_tool") && cannot work as intended: If the output of $() is empty, then without the outer quotes this becomes test -z without an operand for -z, which is a syntax error (of the test command). -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html