John Keeping <john@xxxxxxxxxxxxx> writes: > On Sun, Jan 27, 2013 at 12:11:20PM -0800, Junio C Hamano wrote: >> John Keeping <john@xxxxxxxxxxxxx> writes: >> >> >> Thanks; will queue and wait for an Ack from Michael. >> >> >> >> Does the helper function need to be named with leading underscore, >> >> though? >> > >> > ... Since this is a script >> > not a library module I don't feel strongly about it in this case. >> >> That is exactly why I asked. > > So I think the answer is "habit, but I probably shouldn't have put it > in in this case". OK, then I'll queue with a local amend to drop the leading underscore. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html