On Sat, Jan 26, 2013 at 2:04 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> --- >> builtin/branch.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) > > Forgot to sign-off? Yes > Is this a real problem? Yes. My thoughts yesterday when I happened to type "git branch -D": "Wait, I just entered a delete command without a branch name. It did not report anything, which in UNIX world usually means successful operation. _What_ did it delete??" I knew this code so I just went check. If I did not know, I might as well list all branches I had and see if something was missing. A short message would have saved me the trouble. > I do not see it particularly wrong to succeed after deleting 0 or > more given branch names. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html