Let's try to involve Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> who have met the similar problem recently (according to this thread http://thread.gmane.org/gmane.comp.version-control.git/208297/focus=208310) I recitate myself: >Well, as I understand "current" algorithm: >1. It assumes that file is one-part email message >2. Function searches non-ASCII characters in Subject header >3. If none then it looks non-ASCII characters at message body > >my changes are to skip looking at message body of a multi-part >message as it has parts with their own Content-Type headers > >The said above in details: >1. To set flag when we meet Content-Type: multipart/mixed header >2. After we processed all headers and did not found non-ASCII characters >in a Subject we take a look at this flag and exit with 0 >if it is a multi-part message >>I think your patch is wrong. What happens when we see a Subject: >>line with a non-ascii on it that causes an early return of the loop >>before your new code has a chance to see Content-Type: header? This function is used to determine "broken" (non-ASCII) headers (to be encode them) The problem is if "Subject" is not broken, but message body contains non-ASCII chars, subject is marked as broken and encoded again. P.S. To involved: the beginning of thread is here http://thread.gmane.org/gmane.comp.version-control.git/181743 Alexey Shumkin (1): send-email: Honor multi-part email messages git-send-email.perl | 5 ++++ t/t9001-send-email.sh | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+) -- 1.8.1.1.10.g9255f3f -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html