Jeff King <peff@xxxxxxxx> writes: > This looks good to me. > > The only thing I might add is a test just to double-check that "git help > -a" is parsed correctly. Like: > > test_expect_success 'command completion works without test harness' ' > GIT_TESTING_COMMAND_COMPLETION= run_completion "git bun" && > grep "^bundle\$" out > ' > > (we know we are running bash here, so the one-shot variable is OK to be > used with a function). I think you meant "^bundle $" there, but don't we have the same problem when there is an end-user subcommand "git bunny"? Ahh, ok, we show one element per line and just make sure "bundle" is there, and we do not care what other buns appear in the output. Will squash in, then. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html