Re: [PATCH] cvsserver: detect early of we are up to date and avoid costly rev-list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/9/07, Martin Langhoff <martin@xxxxxxxxxxxxxxx> wrote:
@@ -2194,6 +2197,10 @@ sub update
     my $git_log;
     my $lastcommit = $self->_get_prop("last_commit");

+    if ($lastcommit eq $commitsha1) { # up-to-date
+         return 1;
+    }
+
     # Start exclusive lock here...
     $self->{dbh}->begin_work() or die "Cannot lock database for BEGIN";

Actually, that generates a warning on the initial checkout. The fix is
to run the if as

 if (defined $lastcommit && $lastcommit eq $commitsha1) { # up-to-date

Junio -- is it easy for you to fixup  when you apply the patch?
Otherwise, I'll be happy to repost it patch.

cheers


m
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]