Brandon Casey wrote:
> The <message> part of test_commit() may not be appropriate for a tag name.
> So let's allow test_commit to accept a fourth argument to specify the tag
> name.
Yes!
[...]
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -135,12 +135,13 @@ test_pause () {
> fi
> }
>
> -# Call test_commit with the arguments "<message> [<file> [<contents>]]"
> +# Call test_commit with the arguments "<message> [<file> [<contents> [<tag>]]]"
> #
> # This will commit a file with the given contents and the given commit
> -# message. It will also add a tag with <message> as name.
> +# message. It will also add a tag with <message> as name unless <tag> is
> +# given.
> #
> -# Both <file> and <contents> default to <message>.
> +# <file>, <contents>, and <tag> all default to <message>.
Simpler:
# This will commit a file with the given contents and the given commit
# message and tag the resulting commit with the given tag name.
#
# <file>, <contents>, and <tag> all default to <message>.
With or without that change,
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html