On Thu, Jan 17, 2013 at 09:00:48PM +0000, John Keeping wrote: > On Thu, Jan 17, 2013 at 12:36:33PM -0800, Junio C Hamano wrote: >> John Keeping <john@xxxxxxxxxxxxx> writes: >> >>> Under Python 3 'hasher.update(...)' must take a byte string and not a >>> unicode string. Explicitly encode the argument to this method as UTF-8 >>> so that this code works under Python 3. >>> >>> This moves the required Python version forward to 2.0. >>> >>> Signed-off-by: John Keeping <john@xxxxxxxxxxxxx> >>> --- >> >> Hmph. So what happens when the path is _not_ encoded in UTF-8? > > Do you mean encodable? As you say below it will currently throw an > exception. Now my brain's not working - we shouldn't get an error converting from a Unicode string to UTF-8, so I think this patch is OK as it is. > > Is the repo.hash (and local.hash that gets a copy of it) something > > that needs to stay the same across multiple invocations of this > > remote helper, and between the currently shipped Git and the version > > of Git after applying this patch? > > It's used to specify the path of the repository for importing or > exporting, so it should stay consistent across invocations. However, > this is only an example remote helper so I don't think we should worry > if it changes from one Git release to the next. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html