On Mon, Jan 14, 2013 at 01:05:27PM -0800, Junio C Hamano wrote:
> Michal Privoznik <mprivozn@xxxxxxxxxx> writes:
>
> > +static long parse_algorithm_value(const char *value)
> > +{
> > + if (!value || !strcasecmp(value, "myers"))
> > + return 0;
>
> [diff]
> algorithm
>
> should probably error out.
Definitely.
> Also it is rather unusual to parse the keyword values case insensitively.
Is it? "git grep strcasecmp" shows that we already do so in many cases
(e.g., any bool option, core.autocrlf, receive.deny*, etc). Is there a
reason to reject "Myers" here?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html