On Sun, Jan 13, 2013 at 11:25:57AM +0100, Torsten Bögershausen wrote: > @@ -16,10 +16,10 @@ sub err { > > while (<>) { > chomp; > - /^\s*sed\s+-i/ and err 'sed -i is not portable'; > - /^\s*echo\s+-n/ and err 'echo -n is not portable (please use printf)'; > - /^\s*declare\s+/ and err 'arrays/declare not portable'; > - /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)'; > + /^\s*sed\s+-i\s+\S/ and err 'sed -i is not portable'; > + /^\s*echo\s+-n\s+\S/ and err 'echo -n is not portable (please use printf)'; > + /^\s*declare\s+\S/ and err 'arrays/declare not portable'; > + /^\s*[^#]\s*which\s+[-a-zA-Z0-9]+$/ and err 'which is not portable (please use type)'; The "[^#]" appears to ensure that there's at least one character before the which and that it's not a pound sign. Why is this done? Why isn't it done for the other commands? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html