Re: [PATCH] git-reset --hard: use quotes when we tell the user what HEAD was reset to

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Fredrik Kuivinen" <frekui@xxxxxxxxx> writes:

>> >     I think we need to delimit the name better, probabally we need to quote
>> >     it.  Perhaps something like:
>> >
>> >     HEAD is now at ac9c110: "git-fetch: remove .keep file at the end".
>> ...
> I don't think the second point is much of an issue. Is it really that
> irritating to
> read a word-wrapped line of text? I agree with the first point though, in most
> cases it will not be a problem in other projects.
>
> I still think it is worth doing it, but it certainly isn't super
> important. Feel free
> to drop the patch if you want to.

I do not care much either way, but the third point is that the
quoted output would look "interesting" if the original title
text has double-quoted words.  I.e.

    HEAD is now at 9945d98: "Add "--cacheinfo" option to update-cache."

Notice also your hand-wrapped example has the final full-stop
outside the quote, which your patch would not produce ;-).


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]