Jason Holden <jason.k.holden.swdev@xxxxxxxxx> writes: > Any reason to leave out the maintainers email addresses? Nothing particular, other than that I did not find anywhere in the file that does not break the flow. > My only other suggestion for this series might be to augment the file with > a patch submittal example(s). I found the best example to be in > git-send-email's man page,... I'd feel better to avoid copying and pasting. If send-email has good examples, shouldn't it be sufficient to refer to them? > ----------------------------------------------------------- > Example of sending patches for a new feature: > > Create the patches: > $ git format-patch --cover-letter -M origin/master -o outgoing/ > $ edit outgoing/0000-* > > To send your completed patches for initial consideration: > $ git send-email outgoing/* -to git@xxxxxxxxxxxxxxx -cc gitster@xxxxxxxxx This is ambiguous; it makes it look as if you are CC'ing the maintainer, but for the initial round, it is likely that you are sending it to me only because I have been involved in the area the patch touches. > To send your reviewed patches for inclusion: > $ git send-email outgoing/* -to gitster@xxxxxxxxx -cc git@xxxxxxxxxxxxxxx This is fine, but we would probably want to see it CC'ed to people who reviewed the initial submission, too. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html