Junio C Hamano <gitster@xxxxxxxxx> writes:
> "David A. Greene" <greened@xxxxxxxxxxxxx> writes:
>
>> From: Techlive Zheng <techlivezheng@xxxxxxxxx>
>>
>> Use %B to format the commit message and body to avoid an extra newline
>> if a commit only has a subject line.
>
> Is this an unconditional improvement, or is it generally an
> improvement but for some users it may be a regression? I am
> guessing it is the former but am just making sure.
The former.
>> Author: Techlive Zheng <techlivezheng@xxxxxxxxx>
>>
>> Signed-off-by: David A. Greene <greened@xxxxxxxxxxxxx>
>
> Please don't do "Author: " which does not add anything new. That is
> what "From: " is for. Instead it needs to be a sign-off.
Ok. Unfortunately I sent a number of patches like that. Do you want me
to re-send them?
> Also, is that a real name, I have to wonder?
No idea. Not likely, I'd say.
-David
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html