On Fri, Dec 28, 2012 at 8:40 PM, Adam Spiers <git@xxxxxxxxxxxxxx> wrote:
> On Fri, Dec 28, 2012 at 8:36 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Adam Spiers <git@xxxxxxxxxxxxxx> writes:
>>
>>> Since we have just created a new pathspec-handling library, now is a
>>> good time to add some comments explaining get_pathspec().
>>>
>>> Signed-off-by: Adam Spiers <git@xxxxxxxxxxxxxx>
>>> ---
>>
>> Yes, but we would rather not to see new users of this function added
>> to our codebase in its current form, as explained in the nearby
>> comment. We would want to migrate everybody to "struct pathspec"
>> based interface to support magic pathspecs in the longer term.
>
> I see. Please feel free to drop that patch from the series or amend
> as you see fit.
I've added this sentence to the top of the comments above
get_pathspec():
/*
* N.B. get_pathspec() is deprecated in favor of the "struct pathspec"
* based interface - see pathspec_magic above.
*
[...]
That should be sufficient to discourage people from adding new users
of get_pathspec().
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html