Adam Spiers <git@xxxxxxxxxxxxxx> writes: > diff --git a/pathspec.c b/pathspec.c > new file mode 100644 > index 0000000..8aea0d2 > --- /dev/null > +++ b/pathspec.c > @@ -0,0 +1,99 @@ > +#include "cache.h" > +#include "dir.h" > +#include "pathspec.h" > + > +void fill_pathspec_matches(const char **pathspec, char *seen, int specs) > +{ It did not matter while it was an implementation detail of "git add", but as a public function, something needs to clarify that this "fill"s matches *against the index*, not against a tree or the files in the current directory. The same comment applies to all the internal functions this patch exposes to the outside world. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html