Re: [PATCH 2/8] wildmatch: rename constants and update prototype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:

> @@ -134,101 +131,102 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case)
>  				p_ch = NEGATE_CLASS;
>  #endif
>  			/* Assign literal TRUE/FALSE because of "matched" comparison. */
> -			special = p_ch == NEGATE_CLASS? TRUE : FALSE;
> +			special = p_ch == NEGATE_CLASS;

Leftover comment needs to be reworded as well???

>  			if (special) {
>  				/* Inverted character class. */
>  				p_ch = *++p;
>  			}

I'd prefer "special" used in the "case '['" given a more sensible
name here.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]