Re: Adding spell checker to GIT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,
                   I spell check "//" comments in
in find_ext()

if($_[0] =~ /\.cc|\.java/) {

               $start_pattern  = qr!\s/\*\s|\s//\s!;
       }

and

$chosen_pattern eq qq!\s//\s! ? $end_pattern=qq!\s\014\s! : "End
Pattern Not Found" ;

Also yes i didnt include to use spell checking in string literals , i
thought that would be irregular and cumbersome.

Could you please test the code then i can include it in a seperate file ..?

Regards
Deepak

On 1/6/07, Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote:
Hi,

On Fri, 5 Jan 2007, Deepak Barua wrote:

>         I and sasikumar have designed and built a spell checker into
> the pre-commit hook, could someone please test it and give us your
> comments.

It's a rather big chunk of code, and it is in perl, so I'd rather put it
in another file, but oh well.

There are a few remaining problems, and I don't even know if the second
can be solved:

- you miss "//" comments,
- if the diff is only about a small part of a comment, you do not spell
  check that
- you do not spell check literal messages (i.e. printf("No such fiel!"))

Ciao,
Dscho




--
Code Code Code Away
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]