On Thu, Dec 20, 2012 at 03:44:53PM +0000, Adam Spiers wrote:
> > diff --git a/t/test-lib.sh b/t/test-lib.sh
> > index 256f1c6..31f59af 100644
> > --- a/t/test-lib.sh
> > +++ b/t/test-lib.sh
> > @@ -227,7 +227,7 @@ then
> > pass)
> > tput setaf 2;; # green
> > info)
> > - tput bold; tput setaf 6;; # bold cyan
> > + tput setaf 6;; # cyan
> > *)
> > test -n "$quiet" && return;;
> > esac
> >
>
> Good point, I forgot to check what it looked like with -v. Since this
> series is already on v6, is there a more lightweight way of addressing
> this tiny tweak than sending v7?
It is ultimately up to Junio, but I suspect he would be OK if you just
reposted patch 4/7 with the above squashed. Or even just said "I like
this, please squash it into patch 4 (change info messages from
yellow/brown to bold cyan).
As an aside, it made me wonder how hard/useful it would be to color the
snippets even more. Doing this:
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index f9ccbf2..3d44a94 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -364,7 +364,12 @@ test_expect_success () {
export test_prereq
if ! test_skip "$@"
then
- say >&3 "expecting success: $2"
+ if test -z "$GIT_TEST_HIGHLIGHT"; then
+ say >&3 "expecting success: $2"
+ else
+ say >&3 "expecting success:"
+ echo "$2" | eval "$GIT_TEST_HIGHLIGHT"
+ fi
if test_run_ "$2"
then
test_ok_ "$1"
produces highlighted snippets with:
GIT_TEST_HIGHLIGHT='highlight -S sh -O ansi'
or
GIT_TEST_HIGHLIGHT='pygmentize -l sh'
depending on what you have installed on your system. I'm not convinced
it actually adds anything, but it's a fun toy. A real patch would
probably turn it off in non-verbose mode, as invoking the highlighter
(especially pygmentize) repeatedly is somewhat expensive.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html