Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > entry_count is used in update_one() for two purposes: > > 1. to skip through the number of processed entries in in-memory index > 2. to record the number of entries this cache-tree covers on disk > > Unfortunately when CE_REMOVE is present these numbers are not the same > because CE_REMOVE entries are automatically removed before writing to > disk but entry_count is not adjusted and still counts CE_REMOVE > entries. Nicely explained. I wonder if we can also add a piece of test to the patch 4/4 to demonstrate the issue with CE_REMOVE entries, though. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html