On Sat, Dec 15, 2012 at 06:09:30AM -0500, Jeff King wrote: > > Does > > > > #define error(fmt, ...) (error_impl(fmt, __VA_ARGS__), -1) > > > > cause problems when not used in a return statement? > > Thanks, that was the cleverness I was missing. Here it is as patches. One problem with this method is that if the function implementation ever changes to _not_ return -1, then we get no warning that our macro and the function implementation have diverged in meaning. [1/2]: make error()'s constant return value more visible [2/2]: silence some -Wuninitialized false positives These would go on top of 1/3 from the original series to make -Wall -O3 clean (I'll repost the series as a whole when it is more obvious what we want to do). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html