On Friday 14 December 2012 17:11:44 Jeff King wrote: > [...] > We can fix it by returning "-1" when no note is found (so on > a zero return, we always found a valid value). Good fix. Parsing of the note now always fails if the note doesn't contain the expected string, as it should. > > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > I think this is the right fix, but I am not too familiar with this code, > so I might be missing a case where a missing "Revision-number" should > provide some sentinel value (like "0") instead of returning an error. In > fact, of the two callsites, one already does such a zero-initialization. > > remote-testsvn.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/remote-testsvn.c b/remote-testsvn.c > index 51fba05..5ddf11c 100644 > --- a/remote-testsvn.c > +++ b/remote-testsvn.c > @@ -90,10 +90,12 @@ static int parse_rev_note(const char *msg, struct > rev_note *res) if (end == value || i < 0 || i > UINT32_MAX) > return -1; > res->rev_nr = i; > + return 0; > } > msg += len + 1; > } > - return 0; > + /* didn't find it */ > + return -1; > } > > static int note2mark_cb(const unsigned char *object_sha1, -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html