On Thu, Dec 6, 2012 at 12:01 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Adam Tkac <atkac@xxxxxxxxxx> writes: > >> On Thu, Nov 29, 2012 at 09:33:53AM -0800, Junio C Hamano wrote: >> ... >>> IOW, something along this line? >> >> This won't work, unfortunately, because shopt settings aren't inherited by >> subshell (and for example egrep is called in subshell). >> >> I discussed this issue with colleagues and we found basically two "fixes": >> >> 1. Tell people "do not use aliases which breaks completion script" >> 2. Prefix all commands with "command", i.e. `command egrep` etc. >> >> In my opinion "2." is better long time solution, what do you think? > > Judging from what is in /etc/bash_completion.d/ (I am on Debian), I > think that others are divided. Many but not all prefix "command" in > front of "grep", but nobody does the same for "egrep", "cut", "tr", > "sed", etc. > > If it were up to me, I would say we pick #1, but I cc'ed the people > who have been more involved in our bash-completion code because they > are in a better position to argue between the two than I am. Why not both? I do prefer #1, but I don't see why we wouldn't prefix some commonly problematic ones (\egrep), prefixing all of them seems overkill for me. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html