Erik Faye-Lund <kusmabite@xxxxxxxxx> writes: > On Wed, Dec 5, 2012 at 5:02 PM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > ... > Since we're justifying the approaches, I'd like to explain why I > preferred the return approach: it performs less tests. While this > might sound like premature optimizations, performance is not why I > think it's a good idea. It makes the fix easier to verify; you don't > need to validate that the conditions of the second loop won't happen, > because the code exits quickly. > > If we added something that required cleanup, we could change the > return to a goto with a cleanup-label, and it would still be > relatively easy to see what's going on. > >> However, I have no strong opinion on this, so please apply the version you >> like better. > > Since the issue is present in mainline Git as well, I'd prefer if > Junio merged whatever he prefers. I can produce a proper patch out of > your suggesting, if needed. Thanks; what you and Dscho agreed in this discussion sounds good to me, too. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html