Re: [PATCH v7 p1 07/13] remote-testgit: remove irrelevant test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



felipe.contreras@xxxxxxxxx wrote on Wed, 28 Nov 2012 23:11 +0100:
> This was only to cover a bug that was fixed in remote-testpy not to
> resurface.
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
> ---
>  t/t5801-remote-helpers.sh | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> index 2f7fc10..6801529 100755
> --- a/t/t5801-remote-helpers.sh
> +++ b/t/t5801-remote-helpers.sh
> @@ -53,19 +53,6 @@ test_expect_success 'pushing to local repo' '
>  	compare_refs localclone HEAD server HEAD
>  '
>  
> -# Generally, skip this test.  It demonstrates a now-fixed race in
> -# git-remote-testgit, but is too slow to leave in for general use.
> -: test_expect_success 'racily pushing to local repo' '
> -	test_when_finished "rm -rf server2 localclone2" &&
> -	cp -R server server2 &&
> -	git clone "testgit::${PWD}/server2" localclone2 &&
> -	(cd localclone2 &&
> -	echo content >>file &&
> -	git commit -a -m three &&
> -	GIT_REMOTE_TESTGIT_SLEEPY=2 git push) &&
> -	compare_refs localclone2 HEAD server2 HEAD
> -'
> -

Why does this cause problems?

If you're going to rip it out, please finish the job, and take
out the other two hunks that are needed to trigger this test.  See
7fb8e16 (git-remote-testgit: fix race when spawning fast-import,
2012-04-22).

		-- Pete
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]