gitweb has two bugs in git_patchset_body (now you know who
you are without data-mining with git-blame).
The first bug is a missing "</div>" on commitdiff.
Saw this one a couple of days ago, but was swamped
and had no time to post.
The second bug is displaying a renamed file with the
same name as the one of the preceding "patch". Saw
this one today when I pulled.
To exhibit these, you need to "commitdiff" a commit
which has at least one rename and at least one regular
diff preceding the rename.
Can the guilty parties (you know who you are) please
fix this.
"And while at it" can you please actually *do* "refactor"
git_patchset_body *into smaller functions each one doing
a single particular task*.
It is sad to see git_patchset_body in such despicable state
all the while seeing words like "refactor" in the commit logs
of that function.
git_patchset_body is grossly overloaded for what it is
supposed to do to, and being one single huge blob, it is
hard to maintain.
Thanks,
Luben
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html